Skip to content

[mlpack] Update to 3.4.1#14122

Merged
BillyONeal merged 2 commits intomicrosoft:masterfrom
PhoebeHui:dev/Phoebe/mlpack
Oct 20, 2020
Merged

[mlpack] Update to 3.4.1#14122
BillyONeal merged 2 commits intomicrosoft:masterfrom
PhoebeHui:dev/Phoebe/mlpack

Conversation

@PhoebeHui
Copy link
Contributor

@PhoebeHui PhoebeHui commented Oct 20, 2020 •
edited
Loading

Related to #13536

  1. Update mlpack to latest release revision, and update the patch to match the source change.
  2. Remove 'openblas, lapack' in mlpack dependency since mlpack depends on armadillo, armadillo depends on openblas and lapack, they should handled by armadillo.

All features test pass with x64-windows.

@PhoebeHui PhoebeHui added info:internal category:port-update The issue is with a library, which is requesting update new revision labels Oct 20, 2020
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Oct 20, 2020
@BillyONeal BillyONeal merged commit 21bf5e9 into microsoft:master Oct 20, 2020
@BillyONeal
Copy link
Member

BillyONeal commented Oct 20, 2020

Thanks for your contribution!

@PhoebeHui PhoebeHui deleted the dev/Phoebe/mlpack branch October 21, 2020 07:35
@PhoebeHui PhoebeHui mentioned this pull request Oct 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JackBoosY JackBoosY JackBoosY approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JackBoosY JackBoosY

Labels

category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PhoebeHui @BillyONeal @JackBoosY